Switch from Makefile to mise#81
Draft
google-labs-jules[bot] wants to merge 9 commits into
Draft
Conversation
- Replace legacy Makefile with mise.toml for modern task orchestration. - Replicate all Makefile targets (install, lint, test, docs, etc.) as mise tasks. - Update GitHub Actions workflows to use jdx/mise-action and execute tasks via mise run. - Update docs/README.md to include mise in the features list and setup instructions. - Retain pyproject.toml as the central source of truth for dependencies and tool configurations. - Improve tests/test_app.py to better verify the application's main entry point. - Ensure the project renaming script correctly targets the new configuration setup.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Replace legacy Makefile with mise.toml for modern task orchestration. - Define mise tasks (install, lint, test, docs, app, rename) to wrap existing uv commands. - Update GitHub Actions workflows to use jdx/mise-action@v4, properly handling the Python version matrix. - Update docs/README.md with mise-based setup and usage instructions. - Retain pyproject.toml as the source of truth for project metadata and configurations. - Improve tests/test_app.py and scripts/rename.py to align with the new task runner.
- Replace legacy Makefile with mise.toml for modern task orchestration. - Replicate all Makefile targets (install, lint, test, docs, etc.) as mise tasks using uv. - Update GitHub Actions workflows to use jdx/mise-action@v4, properly handling the Python version matrix via tool_versions. - Update docs/README.md to include mise in the features list and setup instructions. - Retain pyproject.toml as requested for project metadata and configuration. - Improve tests/test_app.py and scripts/rename.py to better support the new system.
amrabed
requested changes
May 11, 2026
amrabed
reviewed
May 11, 2026
amrabed
reviewed
May 11, 2026
- Move documentation dependencies to a dedicated group in pyproject.toml. - Add a hidden install-docs task in mise.toml and make documentation tasks depend on it. - Remove redundant settings from GitHub workflows. - Use tool_versions in mise-action to correctly handle the CI Python matrix.
- Add first-character aliases to tasks (e.g., i for install, t for test). - Use list format for project task aliases to support multiple aliases.
amrabed
requested changes
May 11, 2026
- Update Python version to 3.14 in mise.toml. - Remove redundant env section from mise.toml. - Rename local task to local-docs and assign d alias to it. - Add common shell aliases (i, u, l, t, d, mr) in mise.toml. - Update pyproject.toml author email to an empty string. - Clean up docs/README.md Local environment section. - Use lowercase parameter names in README.md renaming instructions.
amrabed
reviewed
May 12, 2026
amrabed
reviewed
May 12, 2026
- Revert changes to tests/test_app.py and its handling in scripts/rename.py. - Add common shell aliases (ll, la, gc, gp) in mise.toml. - Add dev task in mise.toml to setup dev environment.
- Update AGENTS.md and CONTRIBUTING.md with mise-based setup and commands. - Upgrade Dockerfile to python:3.14-alpine and remove make dependency. - Clean up legacy Makefile settings in .vscode/settings.json. - Update .pre-commit-config.yaml to use mise run lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transitioned the project's task management and environment orchestration from
Makefiletomise.Key changes include:
Makefile.mise.tomlwith tasks forinstall,update,lint,test,docs,app, andrename.miseto automatically manage the virtual environment viauv.check.yml,docs.yml) to usejdx/mise-action, ensuring compatibility with the CI matrix.docs/README.mdto reflect the newmise-based workflow.pyproject.tomlfor project metadata and tool settings as requested.PR created automatically by Jules for task 5194760677358936455 started by @amrabed