Follow-up nit from #436 review.
SOLANA_PRESET_SOURCES in src/Makefile is defined with := (simply-expanded), so the find chain_parsers/visualsign-solana/src/presets -name '*.rs' | sort it runs executes at Makefile-parse time on every make invocation — build, test, lint, narrow-build-check — even though only fmt actually references the variable.
Cheap today, but it's wasted work on every unrelated target and will only get more expensive as the preset tree grows.
Fix: switch to a recursively-expanded = variable, or compute the file list inside the fmt recipe itself, so the find only runs when fmt actually runs.
Follow-up nit from #436 review.
SOLANA_PRESET_SOURCESinsrc/Makefileis defined with:=(simply-expanded), so thefind chain_parsers/visualsign-solana/src/presets -name '*.rs' | sortit runs executes at Makefile-parse time on everymakeinvocation —build,test,lint,narrow-build-check— even though onlyfmtactually references the variable.Cheap today, but it's wasted work on every unrelated target and will only get more expensive as the preset tree grows.
Fix: switch to a recursively-expanded
=variable, or compute the file list inside thefmtrecipe itself, so thefindonly runs whenfmtactually runs.