Skip to content

cli-core: catch-all field-render writeln! uses positional args instead of inline captures #468

Description

@prasanna-anchorage

Follow-up nit from #462 review.

In src/parser/cli-core/src/output.rs the new catch-all field-render arm does:

writeln!(writer, "{} {}: {}", prefix, field.label(), field.fallback_text())?;

prefix is a plain in-scope variable that could be captured inline, but this uses positional format arguments instead, against this repo's "use inline format strings" convention.

Fix: bind field.label()/field.fallback_text() to locals and use writeln!(writer, "{prefix} {label}: {text}")? (or similar) instead of positional args.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions