Repository navigation
Conversation
…I#137) An env (or other) key that is not byte-identical to the page key used to drop the saved Custom endpoint, falsely blocking scheduled/conveyor work.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
An env (or other) key that is not byte-identical to the page key used to
drop the saved Custom endpoint, falsely blocking scheduled/conveyor work.
What changed
providerRuntimeBaseUrlonly used the page-saved Custom endpoint when the run key was byte-identical to the page key (pageCopyRidesWith, #89). That correctly keeps key pools from mixing accounts, but for Custom the destination is the configuration: any env-key drift (or other non-page key) with no competing env URL discarded the saved endpoint (baseUrl: ''). Scheduled/conveyor work then hit a falseblocked_config: "no CUSTOM base URL is saved on this station…", even though the URL was saved.This change: for
requiresBaseUrlproviders, if the page record has both a key and a base URL and the operator did not set an env URL, use that page endpoint even when the run key differs. Key pools stay gated bypageCopyRidesWith. A keyless page URL under an env key stays refused.cronHasCredentialnow resolves the endpoint for the key it is checking (same seam as/api/run).Verification
npm run test:fast—engine-credential.test.js(113 assertions; includes [Bug]: no CUSTOM base URL is saved on this station for this scheduled routine #137 case: env key ≠ page key, keyed page URL, no env URL → endpoint resolves)Safety and truthfulness
Endpoint-only relaxation for
requiresBaseUrlwhen a keyed page record exists and no env URL overrides. Does not share backup key pools across mismatched keys. No new network, secrets surface, permissions, or schema changes. none beyond that.User-reported regression coverage
GitHub #137 (no
qa/bugs/record).Before: Custom URL saved; scheduled/conveyor jobs blocked with "no CUSTOM base URL is saved…".
After: same saved endpoint is used when the run key drifts and no env URL competes; live conveyor/inbox works on the fixed sidecar.
Understanding the interface
not user-facing — credential resolution inside the sidecar. The existing base-URL missing error still applies when no endpoint is actually available.