fix(@angular/cli): dynamically resolve project Angular CLI executable inside MCP tools#33001
Open
clydin wants to merge 1 commit intoangular:mainfrom
Open
fix(@angular/cli): dynamically resolve project Angular CLI executable inside MCP tools#33001clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
clydin
added
the
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a resolveCommand utility to locate the local @angular/cli binary within a workspace, ensuring that ng commands execute using the project-specific CLI version. The LocalWorkspaceHost was updated to utilize this resolution logic. Feedback was provided regarding the use of createRequire, noting that passing a directory path directly may lead to incorrect module resolution relative to the parent directory.
… inside MCP tools The MCP server host runtime now dynamically resolves the precise Angular CLI binary from the workspace's node_modules rather than relying on global system path invocations. This guarantees full compatibility between a project's specific configuration constraints and the active framework version, preventing mismatches across monorepos or containerized setups.
clydin
force-pushed
the
mcp/ng-bin-discovery
branch
from
46068a7 to
638257d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP server host runtime now dynamically resolves the precise Angular CLI binary from the workspace's node_modules rather than relying on global system path invocations. This guarantees full compatibility between a project's specific configuration constraints and the active framework version, preventing mismatches across monorepos or containerized setups.