Skip to content

Redesign of all resizeable screens#21169

Open
Haz3-jolt wants to merge 2 commits into
ankidroid:mainfrom
Haz3-jolt:ne-fixup
Open

Redesign of all resizeable screens#21169
Haz3-jolt wants to merge 2 commits into
ankidroid:mainfrom
Haz3-jolt:ne-fixup

Conversation

@Haz3-jolt

@Haz3-jolt Haz3-jolt commented May 28, 2026

Copy link
Copy Markdown
Member

Purpose / Description

A sizable group of users have complained about the following:

  1. Resizable panes appearing on vertical mode in smaller tablets
  2. Not wanting multi-fragment screens

Fixes

Approach

  • Moves all the multi-fragment container screens to w840dp as suggested by @BrayanDSO
  • Adds a pref toggle in appearance to disable all multi-fragment screens to become single fragment.

How Has This Been Tested?

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@Haz3-jolt
fix(splitPanes): raise split layout breakpoint from sw600dp to w840dp
a4ae611 
Move all split-pane layouts (note editor, card browser, card template
editor, deck picker) from layout-sw600dp to layout-w840dp, switching
from smallest-width to current-width qualifier and raising the threshold
to the Material 'expanded' window size class (840 dp).

This prevents split panes from activating on smaller 7-8 inch tablets,
especially in portrait mode, where the two panes are too narrow to be
usable.

Fixes ankidroid#21010
@Haz3-jolt Haz3-jolt force-pushed the ne-fixup branch 2 times, most recently from 94cc488 to b6939ac Compare May 28, 2026 23:28
@github-actions

github-actions Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • PreferencesScreenshotTest: 1 change
All 1 changed screenshots

PreferencesScreenshotTest

  • AppearanceSettingsFragment_compare.png

@ZornHadNoChoice

ZornHadNoChoice commented May 29, 2026

Copy link
Copy Markdown
Collaborator
  • Moves all the multi-fragment container screens to w840dp as suggested by @BrayanDSO
  • Adds a pref toggle in appearance to disable all multi-fragment screens to become single fragment.

Since we have a toggle, why not disable it by default and keep the current screen size bound?

Current users who like this feature would be upset if it was removed because of the new size requirement.

@Haz3-jolt
feat(splitPanes): add app-wide split view toggle in Appearance settings
cf550e8 
Add a 'Split view' toggle under Settings > Appearance > Layout.
Defaults to on. When turned off, all split panes (note editor, card
browser, card template editor, deck picker) are disabled and the
screens behave as single-pane regardless of display size.

This gives users on large screens the option to opt out of the
side-by-side layout entirely.

Assisted-by: Claude Opus 4.6
@david-allison

david-allison commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

As it stands, we couldn't cherry-pick this into 2.24.1 (.1 should only contain bugfixes), could you split this PR into two:

  • fixing the screen size detection regression
  • adding a preference for 2.25

I don't feel w840dp is sufficiently justified with testing. We've moved from x-large to sw600dp and now to another value.

When we make this change, there should be justification on why we selected it, so future develoeprs have context if they wish to change this value in future

EDIT: We should also consider tall phones, and whether this would push them into landscape mode.

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label May 29, 2026
@BrayanDSO

BrayanDSO commented Jun 1, 2026

Copy link
Copy Markdown
Member

I still prefer this as a Toggle sidebar option on the menu of each screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Has Conflicts Needs Author Reply Waiting for a reply from the original author Needs Review Strings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Tablet] Reconsider design of Note Editor Previewer

4 participants

@Haz3-jolt @ZornHadNoChoice @david-allison @BrayanDSO