Fix: Adjust FAB position and fix animation snap-back (#21241)

[vivek41-glitch]

Description

Fixes #21241

Changes

• Increased FAB bottom margin from 16dp to 24dp to fix button position being too low
• Fixed animation snap-back by correcting translationY values on close animation

How to Test

1. Open DeckPicker screen with some decks in the list
2. Tap the FAB (+) button
3. Observe menu opens smoothly with all 4 options
4. Tap outside or press back
5. Observe menu closes without snap-back
6. Verify FAB position is higher than before

Screenshots/Recordings

Before:

604942821-4045e6dd-abe0-4698-8afc-696168604750.mp4

After:

WhatsApp.Video.2026-06-13.at.10.46.52.mp4

Checklist

• I have tested my changes
• Changes only affect FAB positioning and animation
• No unrelated changes included
• PR is on a separate branch

[github-actions]

Snapshot diff report vs main. Open screenshot-diff for diffs.

• DeckPickerScreenshotTest: 3 changes
• DeckPickerTabletScreenshotTest: 1 change

All 4 changed screenshots

DeckPickerScreenshotTest

• baseState_compare.png
• edgeToEdge_30_decks_compare.png
• fabExpanded_compare.png

DeckPickerTabletScreenshotTest

• 30_decks_tablet_compare.png

[criticalAY]

thankyou! could you please revert to the original GitHub template? Also, add a screen recording for the changes you have done, your previous PRs also have the same pattern of removing the template and setting something new please stick to the one provided

[vivek41-glitch]

@criticalAY I've updated the PR description to follow the template. I will add the screen recording shortly. Sorry for the mistake!

[vivek41-glitch]

@criticalAY , actually I am having local build environment issues on Windows (AAPT2 daemon startup failed) and cannot generate a debug APK to record the fix.
The code changes are clean and only affect these 2 files. The automated checks have all passed and the screenshot diff confirms visual changes.
so if possible then can u just review this directly , or if any other way to record is there so u can guide or tell me
thanks

[vivek41-glitch]

Screen.Recording.2026-06-10.231816.mp4

@criticalAY, hear is recording , all fixes running properly , and that recording is bit lagging so ignore this and in real app , it is working great .ready for final review

[david-allison]

That video shows the collection in the "no cards" state, not what was reported

[vivek41-glitch]

@david-allison , got it
Please check this

20260611-0130-46.7787009.mp4

[david-allison]

That doesn't look correct

[vivek41-glitch]

WhatsApp.Video.2026-06-13.at.10.46.52.mp4

@david-allison , please review this , and tell me if any chnages need in pr

[david-allison]

The 'files changed' tab has a fair few changes which don't seem relevant

[david-allison]

This also isn't fixed. See: #21241 (comment)

[vivek41-glitch]

@david-allison Thanks for tracking down the real cause — makes sense that this traces back to #20964 rather than being a static margin issue.

Since this looks like a race condition between the window insets listener and the FAB's layout-change listener (rather than something a margin tweak can fix), I don't want to guess at a fix blindly again. Could you point me toward the approach you'd want here — for example, should the recycler view padding update be deferred until after the FAB's padding is fully applied, or is there a different fix you had in mind?

Happy to implement whatever direction you'd like, just want to make sure I'm fixing the actual race rather than masking it again.

[david-allison]

Please see our https://github.com/ankidroid/Anki-Android/blob/main/AI_POLICY.md

You have more context, but it seems best to chain the layout dependency, maybe even defining the constraints in the code.

[vivek41-glitch]

okay , @david-allison , i got ur hint and now as u said i m going to do make the recyler view's pading update only happen after the fabs padding .