fix(startup): handle when the user has not decided the storage type (App-Private/Public)#21290
Open
david-allison wants to merge 3 commits into
Open
fix(startup): handle when the user has not decided the storage type (App-Private/Public)#21290david-allison wants to merge 3 commits into
david-allison wants to merge 3 commits into
Conversation
This is planned to be moved to anki-common, but not yet feasible Assisted-by: Claude Fable 5
...by redirecting to IntentHandler This fixes a bug in Reviewer and other entry points (see fixed test), and hardens/standardizes other collection validation in the app Assisted-by: Claude Fable 5 - implemented after a long discussion, comments and naming are mine
...by throwing, as a program using the API needs to surface this issue to a user. Assisted-by: Claude Fable 5 - implemented
5395462 to
30d1c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
This is theoretical and works in order to get
ExternalEntryPointsUndecidedStorageTestworking.I want to move AnkiDroid away from implicit collection creation in
withColinto a deferred 'startup' path in order to remove complexity, allow for easy migration ofCollectionHelper/CollectionManagerto:anki-common, and better support for choosing a non-public AnkiDroid folder:full(F-Droid/GitHub) releases users to grant theAll files accesspermission #13574Fixes
Approach
If the storage location is undecided:
IntentHandlerif in the appHow Has This Been Tested?
This code exists to make a unit test pass
Checklist