fix(select): prevent trigger class from leaking to dropdown content and items#17576
Open
Momoyu404 wants to merge 5 commits intoanomalyco:devfrom
Open
fix(select): prevent trigger class from leaking to dropdown content and items#17576Momoyu404 wants to merge 5 commits intoanomalyco:devfrom
Momoyu404 wants to merge 5 commits intoanomalyco:devfrom
Conversation
Author
|
Hi! Just wanted to follow up on this PR 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17545
Type of change
What does this PR do?
The
Selectcomponent was forwardingclass/classListprops to three elements: the trigger button, the dropdown content panel, and each item.In
prompt-input.tsx, the agent selector passesclass="max-w-[160px]"to keep the trigger compact. This unintentionally capped the popup width at 160px too, clipping long agent names from plugins like GSD.Fix: only apply
classListtoKobalte.Trigger. The content and items don't need it —select.cssalready handles their sizing.Changed file:
packages/ui/src/components/select.tsxHow did you verify your code works?
Ran the app locally (
bun devinpackages/app), opened a session with GSD agents loaded, and confirmed the dropdown now expands to show full agent names without clipping. Checked that settings page selects are unaffected.Screenshots / recordings
Before:

After:

Checklist