fix: custom azure provider apiKey config with completionUrl#21843
Open
watermarkhu wants to merge 3 commits intoanomalyco:devfrom
Open
fix: custom azure provider apiKey config with completionUrl#21843watermarkhu wants to merge 3 commits intoanomalyco:devfrom
watermarkhu wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a provider initialization edge case so custom/bundled provider “custom loaders” (notably Azure’s useCompletionUrls selection logic) are registered even when the provider is configured solely via config options.apiKey (without env vars or /connect stored auth).
Changes:
- Treat config-sourced providers with
options.apiKeyas “configured” for purposes of registering custom model/vars/discovery loaders. - Ensures Azure’s custom model loader is available in config-only setups, enabling options like
useCompletionUrls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #13873
Type of change
What does this PR do?
Allow custom Azure endpoint configuration using config file only and without setting
AZURE_API_KEYor manually connect with/connect.Currently, if
AZURE_API_KEYis not set, and when the azure configuration comes only from the config file, the azure model loader is skipped. This means that azure handler optionuseCompletionUrlswill not be available.This fix ensures that the model loader is also registered when the provider exists as a config-sourced entry with a
apiKeyin its options.If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
After this change, I've unset the
AZURE_API_KEY, and disconnected the provider. Now, with the following config, the connection is valid.Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.