fix(acp): stop emitting user_message_chunk during session/prompt turn#21851
Open
RAIT-09 wants to merge 2 commits intoanomalyco:devfrom
Open
fix(acp): stop emitting user_message_chunk during session/prompt turn#21851RAIT-09 wants to merge 2 commits intoanomalyco:devfrom
RAIT-09 wants to merge 2 commits intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21708
Type of change
What does this PR do?
Removes the
user_message_chunkemission from the livemessage.part.updatedhandler duringsession/promptturns.Per the ACP spec,
user_message_chunkshould only be sent duringsession/loadorsession/forkto replay conversation history. #18625 added this emission on the live prompt path to align output between live and replay paths, but ACP clients already know the message they sent — the echo causes duplicate display.This change only affects the live prompt path.
session/loadandsession/forkreplay behavior is unchanged.How did you verify your code works?
Screenshots / recordings
Before:


After:

Checklist