refactor(config): pass instance context to containsPath#21882
Open
Brendonovich wants to merge 1 commit intodevfrom
Open
refactor(config): pass instance context to containsPath#21882Brendonovich wants to merge 1 commit intodevfrom
Brendonovich wants to merge 1 commit intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This alleviates an error we've been seeing in Electron builds that embed the server rather than using the CLI.
Accessing
InstanceinsidecontainsPathfails in some specific circumstances where ALS context seems to not be carried over. To remedy this I've madecontainsPathaccept an optional override forInstancewhich in this case we use to pass the currentInstanceRefvalue. This keeps retrieval ofInstanceContextwithin Effect instead of relying on ALS. A cleaner solution is probably possible but this works for now.