feat(scrollbox): preserve scroll position across resize#835
Open
benkoppe wants to merge 1 commit intoanomalyco:mainfrom
Open
feat(scrollbox): preserve scroll position across resize#835benkoppe wants to merge 1 commit intoanomalyco:mainfrom
benkoppe wants to merge 1 commit intoanomalyco:mainfrom
Conversation
benkoppe
requested review from
Hona,
kommander,
msmps and
simonklee
as code owners
benkoppe
force-pushed
the
scrollbox-resize
branch
from
1beb449 to
555cab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for your work with this repo. I use opencode in a workflow that causes it to get resized relatively often, and currently that causes large and unpredictable jumps in the scroll box, which can be jarring and very annoying.
This PR addresses the issue by snapshotting pre-resize state and restoring. The first visible child is used as an anchor, and
distanceFromBottomis used as a fallback when anchor IDs aren't available. Here's the behavior before and after:Before
Screen.Recording.2026-03-19.at.1.12.38.PM.mov
After
Screen.Recording.2026-03-19.at.1.15.57.PM.mov
Regression tests are also included in a new file,
scrollbox-resize-preserve.test.ts, which defines aScrollBoxResizeScenarioclass ease test creation.