Skip to content

fix(native): terminal not updated on new capabilities #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnatoleLucet wants to merge 2 commits into
base: main
Choose a base branch
from
+28 −3
Open

fix(native): terminal not updated on new capabilities #877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
244d274
fix(native): terminal not updated on new capabilities
AnatoleLucet Mar 26, 2026
1fcd34b
Merge branch 'main' into fix/capabilites-initial-render
simonklee Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions packages/core/src/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,7 @@ export class CliRenderer extends EventEmitter implements RenderContext {
private minTargetFrameTime: number = 1000 / this._maxFps
private immediateRerenderRequested: boolean = false
private updateScheduled: boolean = false
private forceNextRender: boolean = false

private liveRequestCounter: number = 0
private _controlState: RendererControlState = RendererControlState.IDLE
Expand Down Expand Up @@ -930,11 +931,15 @@ export class CliRenderer extends EventEmitter implements RenderContext {
return this.realStdoutWrite.call(this.stdout, chunk, encoding, callback)
}

public requestRender() {
public requestRender(force: boolean = false) {
if (this._controlState === RendererControlState.EXPLICIT_SUSPENDED) {
return
}

if (force) {
this.forceNextRender = true
}

if (this._isRunning) {
return
}
Expand Down Expand Up @@ -1376,9 +1381,27 @@ export class CliRenderer extends EventEmitter implements RenderContext {

private capabilityHandler: (sequence: string) => boolean = ((sequence: string) => {
if (isCapabilityResponse(sequence)) {
const prev = this._capabilities

this.lib.processCapabilityResponse(this.rendererPtr, sequence)
this._capabilities = this.lib.getTerminalCapabilities(this.rendererPtr)
this.emit(CliRenderEvents.CAPABILITIES, this._capabilities)

const shouldRender =
!prev ||
prev.rgb !== this._capabilities.rgb ||
prev.kitty_graphics !== this._capabilities.kitty_graphics ||
prev.sixel !== this._capabilities.sixel ||
prev.hyperlinks !== this._capabilities.hyperlinks ||
prev.explicit_width !== this._capabilities.explicit_width ||
prev.explicit_cursor_positioning !== this._capabilities.explicit_cursor_positioning ||
prev.scaled_text !== this._capabilities.scaled_text ||
prev.unicode !== this._capabilities.unicode

if (shouldRender) {
this.requestRender(true)
}

return true
}
return false
Expand Down Expand Up @@ -2391,8 +2414,10 @@ export class CliRenderer extends EventEmitter implements RenderContext {
throw new Error("Rendering called concurrently")
}

let force = false
if (this._splitHeight > 0) {
let force = this.forceNextRender
this.forceNextRender = false

if (!force && this._splitHeight > 0) {
// TODO: Flickering could maybe be even more reduced by moving the flush to the native layer,
// to output the flush with the buffered writer, after the render is done.
force = this.flushStdoutCache(this._splitHeight)
Expand Down