Open
Conversation
Member
|
This breaks the tmux-via-xtversion flow the PR is trying to fix. After the first unwrapped xtversion response, term_info is "tmux", but self.in_tmux has not been updated yet when sendPendingQueries() runs. With the new self.in_tmux checks, the wrapped retry xtversion / capability / graphics queries are skipped in that case. The old self.in_tmux or self.isXtversionTmux() logic handled this. The test was also changed to set term.in_tmux = true up front, so it no longer covers the real transition. |
62aa6b7 to
81d3583
Compare
Author
|
ah! indeed that's my mistake. |
81d3583 to
f79cb9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently
hyperlinksneed the terminal name to know if they are supported or not.and the terminal name is either found using xtversion or
TERM_PROGRAM=.when running under tmux, the xtversion simply returns
tmux, it does not return the real terminal's xtversion.and
TERM_PROGRAM=will more often than not be set to*-256color, which does not give use the terminal name either.this will result in
hyperlinksbeing detected as unsupported even though the user is running in an OSC8 compliant terminal.to fix this, i added an extra DSC wrapped
xtversionquery to make sure we get the proper terminal name under tmux.i also cleaned the logic a bit around
is_tmuxbecause it was inconsistent.[main] left kitty w/ tmux, right kitty w/o tmux
screenrecording-2026-03-26_13-27-09.mp4
[this pr] left kitty w/ tmux, right kitty w/o tmux
screenrecording-2026-03-26_13-25-44.mp4