✨ Quality: Missing matrixWorldNeedsUpdate in overridden updateMatrix#884
Open
chinhkrb113 wants to merge 1 commit intoanomalyco:mainfrom
Conversation
…trix When overriding `updateMatrix` on a Three.js `Object3D` (or `Sprite`), you must set `this.matrixWorldNeedsUpdate = true`. Without this, the object's world matrix will not be recalculated when its local transform changes, causing the sprite to appear frozen in place, incorrectly scaled, or improperly rotated in the scene. Affected files: SpriteUtils.ts Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
chinhkrb113
requested review from
Hona,
kommander,
msmps and
simonklee
as code owners
Member
|
I have questions about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Code Quality
Problem
When overriding
updateMatrixon a Three.jsObject3D(orSprite), you must setthis.matrixWorldNeedsUpdate = true. Without this, the object's world matrix will not be recalculated when its local transform changes, causing the sprite to appear frozen in place, incorrectly scaled, or improperly rotated in the scene.Severity:
highFile:
packages/core/src/3d/SpriteUtils.tsSolution
When overriding
updateMatrixon a Three.jsObject3D(orSprite), you must setthis.matrixWorldNeedsUpdate = true. Without this, the object's world matrix will not be recalculated when its local transform changes, causing the sprite to appear frozen in place, incorrectly scaled, or improperly rotated in the scene.Changes
packages/core/src/3d/SpriteUtils.ts(modified)Testing
🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #883