fix: use new URL() instead of import with { type: file } for cross-runtime compat#918
Merged
simonklee merged 2 commits intoanomalyco:mainfrom Apr 10, 2026
Merged
Conversation
…ntime compat
The Bun-specific `import ... with { type: "file" }` syntax is not
supported by Deno or Node. Replace with `new URL(path, import.meta.url)`
+ `fileURLToPath()` which works identically across all runtimes.
Update the generator (assets/update.ts) to produce cross-runtime
compatible code so future regeneration preserves this change.
lu-zero
requested review from
Hona,
kommander,
msmps and
simonklee
as code owners
Collaborator
|
I see the issue. This weird generation was to support Bun standalone executables bundling the existing default parsers and queries I think. Need to check if that still works this way for opencode. |
simonklee
approved these changes
Apr 10, 2026
Member
simonklee
left a comment
simonklee
left a comment
There was a problem hiding this comment.
Tested with opencode and for me the highlights still work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bun-specific
import ... with { type: "file" }syntax is not supported by Deno or Node. Replace withnew URL(path, import.meta.url)+fileURLToPath()which works identically across all runtimes.Update the generator (assets/update.ts) to produce cross-runtime compatible code so future regeneration preserves this change.