Skip to content

fix: full repaint on resume to fix transparency artifacts in Kitty #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acegikmoo wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −1
Open

fix: full repaint on resume to fix transparency artifacts in Kitty #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
876fe79
fix: full repaint on resume to fix transparency artifacts in Kitty
acegikmoo Apr 6, 2026
b21b942
resolve conflicts after rebase
acegikmoo Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core/src/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2110,7 +2110,9 @@ export class CliRenderer extends EventEmitter implements RenderContext {
this.enableMouse()
}

this.currentRenderBuffer.clear(this.backgroundColor)
// Normal diff skips unchanged cells leaving transparency visible. force=true repaints all.
this.lib.render(this.rendererPtr, true)

this._controlState = this._previousControlState

if (
Expand Down
21 changes: 21 additions & 0 deletions packages/core/src/tests/renderer.control.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,27 @@ test("resume() restores previous AUTO_STARTED state and restarts rendering", ()
expect(renderer.isRunning).toBe(true)
})

test("resume() triggers a force render to fix transparency artifacts", () => {
renderer.start()
renderer.suspend()

let forceRenderCalled = false

// @ts-expect-error - lib is private
const originalRender = renderer.lib.render.bind(renderer.lib)
// @ts-expect-error - lib is private
renderer.lib.render = (ptr: any, force: boolean) => {
if (force) forceRenderCalled = true
return originalRender(ptr, force)
}

renderer.resume()
expect(forceRenderCalled).toBe(true)

// @ts-expect-error - lib is private
renderer.lib.render = originalRender
})

test("stop() transitions to EXPLICIT_STOPPED and stops rendering", () => {
renderer.start()
expect(renderer.isRunning).toBe(true)
Expand Down