feat(core): support ANSI 16 colors for borderColor and backgroundColor#932
Open
seffhunnn wants to merge 1 commit intoanomalyco:mainfrom
Open
feat(core): support ANSI 16 colors for borderColor and backgroundColor#932seffhunnn wants to merge 1 commit intoanomalyco:mainfrom
seffhunnn wants to merge 1 commit intoanomalyco:mainfrom
Conversation
Author
|
Added a TypeScript-only fix that preserves ANSI 16 palette metadata through the Box rendering pipeline, with end-to-end tests for named color behavior. Local TS tests are passing; Box integration verification is expected to complete in CI because native binaries are unavailable locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves ANSI 16 named colors for
borderColorandbackgroundColorinstead of always converting them into truecolor RGB escape sequences.This allows terminal themes and SSH client palettes to map colors correctly for named colors such as
"red","blue", and"brightCyan".Changes
RGBATesting
bun test src/lib/RGBA.test.ts→ 131 passingbun test src/renderables/Box.test.tsrequires native binary package (@opentui/core-win32-x64) unavailable locally, expected to run in CICloses #852