workaround windows terminal bug when sending XTVERSION before alt screen#934
Closed
workaround windows terminal bug when sending XTVERSION before alt screen#934
Conversation
There was a problem hiding this comment.
Pull request overview
Reorders terminal initialization in the Zig CLI renderer so startup capability queries (notably XTVERSION) are sent only after alternate-screen setup, avoiding a Windows Terminal stall reported in #933 while keeping the existing detection/query logic unchanged.
Changes:
- Move
setupTerminalWithoutDetection(useAlternateScreen)to run beforeterminal.queryTerminalSend(...) - Keep query send and flushing behavior the same, only changing ordering
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
upstream WT has kindly fixed this quickly... won't need this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XTVERSIONbefore entering alt-screenTesting
Closes #933