feat(core): add input type password with character masking#936
Closed
LeTamanoir wants to merge 8 commits intoanomalyco:mainfrom
Closed
feat(core): add input type password with character masking#936LeTamanoir wants to merge 8 commits intoanomalyco:mainfrom
LeTamanoir wants to merge 8 commits intoanomalyco:mainfrom
Conversation
Add a mask_codepoint field to EditorView that replaces all rendered characters with a single codepoint when set. The masking is applied at the rendering layer (drawTextBufferInternal) so the edit buffer is never modified. Placeholder text is excluded from masking. Signed-off-by: LeTamanoir <martin.saldinger@kiln.fi>
Add a `type` prop ("text" | "password") and `passwordChar` prop to
InputRenderable. When type is "password", displayed characters are
replaced with the mask character (default "●") while the real value
stays intact in the edit buffer.
Signed-off-by: LeTamanoir <martin.saldinger@kiln.fi>
Signed-off-by: LeTamanoir <martin.saldinger@kiln.fi>
Signed-off-by: LeTamanoir <martin.saldinger@kiln.fi>
Warn and fall back to the default mask character when passwordChar is not exactly one character, matching the parseBorderStyle pattern. Signed-off-by: LeTamanoir <martin.saldinger@kiln.fi>
Signed-off-by: LeTamanoir <martin.saldinger@kiln.fi>
LeTamanoir
requested review from
Hona,
kommander,
msmps and
simonklee
as code owners
Signed-off-by: LeTamanoir <martin.saldinger@kiln.fi>
LeTamanoir
force-pushed
the
feat/input-password-type
branch
from
920a472 to
f954606
Compare
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
Member
Closing since it's not the right approach. |
Contributor
Author
|
okay will try in the input renderable then 👍 |
Member
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typeprop ("text" | "password") andpasswordCharprop to<input>type="password", all rendered characters are replaced with a mask character (default●) while the edit buffer retains the real valuemask_codepointfield onEditorView, so cursor, selection, and navigation all work unchanged