fix: deleteToLineStart joins with previous line when cursor at col 0#938
Merged
simonklee merged 3 commits intoanomalyco:mainfrom Apr 10, 2026
Merged
fix: deleteToLineStart joins with previous line when cursor at col 0#938simonklee merged 3 commits intoanomalyco:mainfrom
simonklee merged 3 commits intoanomalyco:mainfrom
Conversation
simonklee
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deleteToLineStart()doing nothing when the cursor is at column 0 with row > 0editBuffer.deleteCharBackward()to remove the newline and join with the previous lineDetails
EditBufferRenderable.deleteToLineStart()only deletes whencursor.col > 0. After clearing a line's content, the cursor sits at col 0 and subsequent calls are no-ops. This makes repeated Ctrl+U presses get stuck instead of continuing to delete line-by-line upward.The fix adds an
else if (cursor.row > 0)branch that callseditBuffer.deleteCharBackward()to remove the newline character, matching the behavior users expect from terminals and editors.Tests
Added 4 new tests in
Textarea.editing.test.ts:Closes #937