Skip to content

fix(docs): replace broken Alipay preview QR - #18

Open
liang0417 wants to merge 1 commit into
ant-design:mainfrom
liang0417:codex/fix-broken-alipay-qr
Open

liang0417 wants to merge 1 commit into
ant-design:mainfrom
liang0417:codex/fix-broken-alipay-qr

Conversation

@liang0417

@liang0417 liang0417 commented Sep 8, 2026 •

Copy link
Copy Markdown

Summary

  • remove the Alipay QR that encodes the placeholder URL https://render.alipay.com/p/s/x-markdown-mini-demo, which now redirects to Alipay's 404 page
  • show an explicit localized unavailable state instead of offering a dead scan target
  • reuse the existing accessible locked-state UI and remove the now-unused qrcode.react dependency

No replacement mini-program URL is publicly available, so this keeps the playground accurate without inventing a destination. A future live URL can restore the QR deliberately.

Verification

pm test — 28 files / 255 tests passed

pm run docs:buildn- pm run check:examplesn- verified the production bundle no longer contains the dead URL and includes both localized unavailable messages

Related to ant-design/x#2048.

Summary by CodeRabbit

  • 功能调整
    • 扫码面板不再显示实时支付宝二维码。
    • 支付宝与微信设备预览统一显示锁定占位状态。
  • 文案更新
    • 更新支付宝设备预览暂不可用的提示文案。
    • 优化中英文界面中的不可用状态说明。

@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3d811025-f1a9-4353-8ec1-e4e5ed9ff9fa

📥 Commits

Reviewing files that changed from the base of the PR and between 5a247ed and ad2c8b4.

📒 Files selected for processing (3)
  • docs-site/package.json
  • docs-site/src/components/Playground/ScanPanel.tsx
  • docs-site/src/components/Playground/index.less

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

文档站点移除 Alipay QR code 依赖和渲染。Alipay 与 WeChat 现在都显示锁定占位内容,并使用各自的提示文案。

Changes

设备预览状态

Layer / File(s) Summary
预览文案与依赖
docs-site/package.json, docs-site/src/components/Playground/ScanPanel.tsx
移除 qrcode.react 依赖和 QR code 相关声明。新增 Alipay 不可用文案,并更新中英文提示。
锁定预览渲染
docs-site/src/components/Playground/ScanPanel.tsx, docs-site/src/components/Playground/index.less
Alipay 与 WeChat 统一使用锁定占位状态。更新占位符注释。

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ad2c8

Alipay device preview now presents a localized unavailable state instead of a broken QR destination, and WeChat retains the same locked-preview behavior. The change is ready to merge with no identified current risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了主要变更:将损坏的 Alipay 预览二维码替换为不可用状态。标题简洁、具体,并与变更内容一致。
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

小兔看到扫码窗,
Alipay 暂停亮 QR 光。
WeChat 一同守占位,
中英文案已更新。
依赖轻装向前跑。

Comment @coderabbitai help to get the list of available commands.

@liang0417

Copy link
Copy Markdown
Author

Hi @Div627, PR #18 has been approved and all CI checks have passed. It is currently blocked by the repository's branch rules. Could you please take a look and merge it when convenient if everything is ready? Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants