refactor: remove Mermaid custom action slots#108
Merged
Conversation
6f05309 to
f74ed58
Compare
f74ed58 to
d9e3f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
Mermaid custom action slots made the header customization semantics confusing because the header slot replaces the whole header area. This removes customActionIconRender and customActionRender from the Mermaid slot API while keeping typed slots for the supported header slot.
The Mermaid docs demos have also been aligned with /Users/carl/Desktop/repo/oss/x/packages/x/components/mermaid/demo:
Where Vue slots are available, the demos prefer slots, such as the Mermaid header slot and Bubble content slot. Custom action icons remain item data because Mermaid does not expose the underlying Actions iconRender slot.
Validation:
📝 Change Log