Skip to content

refactor: remove Mermaid custom action slots#108

Merged
cc-hearts merged 1 commit into
mainfrom
codex/mermaid-remove-custom-action-slots
Jun 19, 2026
Merged

refactor: remove Mermaid custom action slots#108
cc-hearts merged 1 commit into
mainfrom
codex/mermaid-remove-custom-action-slots

Conversation

@cc-hearts

@cc-hearts cc-hearts commented Jun 19, 2026

Copy link
Copy Markdown
Member

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

🔗 Related Issues

💡 Background and Solution

Mermaid custom action slots made the header customization semantics confusing because the header slot replaces the whole header area. This removes customActionIconRender and customActionRender from the Mermaid slot API while keeping typed slots for the supported header slot.

The Mermaid docs demos have also been aligned with /Users/carl/Desktop/repo/oss/x/packages/x/components/mermaid/demo:

  • Basic
  • Custom Header
  • Header Actions
  • With XMarkdown
  • Semantic DOM

Where Vue slots are available, the demos prefer slots, such as the Mermaid header slot and Bubble content slot. Custom action icons remain item data because Mermaid does not expose the underlying Actions iconRender slot.

Validation:

  • vp test packages/x/components/mermaid/tests/index.test.tsx
  • vp check --fix via the staged-files commit hook
  • vp check (format passes; existing unrelated lint/type issues remain)

📝 Change Log

Language Changelog
🇺🇸 English Remove Mermaid custom action slots and align Mermaid demos with upstream examples.
🇨🇳 Chinese 移除 Mermaid 自定义操作项 slots,并对齐 Mermaid 示例与上游示例。

@cc-hearts cc-hearts force-pushed the codex/mermaid-remove-custom-action-slots branch 2 times, most recently from 6f05309 to f74ed58 Compare June 19, 2026 12:23
@cc-hearts cc-hearts force-pushed the codex/mermaid-remove-custom-action-slots branch from f74ed58 to d9e3f45 Compare June 19, 2026 12:34
@cc-hearts cc-hearts merged commit 34c7741 into main Jun 19, 2026
1 check passed
@cc-hearts cc-hearts deleted the codex/mermaid-remove-custom-action-slots branch June 19, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant