Repository navigation
Fix copy buttons on the web build over plain HTTP - #40
Merged
Merged
Conversation
The engine's only web clipboard strategy is navigator.clipboard, which browsers expose in a secure context alone, so every copy button failed on http://admin.awl. Route copying through a new lib/clipboard_interop/ package: the Clipboard API first, falling back to execCommand, ported from the engine's own strategy removed in flutter/flutter#171427 Also make failure visible. None of the three call sites survived a throw, and the Peer ID button announced success before awaiting the copy, which sent the user off to paste an empty clipboard. All three now catch and report, sharing one message; two regression tests cover it. Verified by hand on http://admin.awl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes anywherelan/awl#200
The engine's only web clipboard strategy is navigator.clipboard, which browsers expose in a secure context alone, so every copy button failed on http://admin.awl. Route copying through a new lib/clipboard_interop/ package: the Clipboard API first, falling back to execCommand, ported from the engine's own strategy removed in flutter/flutter#171427
Also make failure visible. None of the three call sites survived a throw, and the Peer ID button announced success before awaiting the copy, which sent the user off to paste an empty clipboard. All three now catch and report, sharing one message; two regression tests cover it.
Verified by hand on http://admin.awl