Skip to content

Add breeze ci audit for the fork CI setup - #74823

Open
potiuk wants to merge 2 commits into
fork-ci-3-reconcilerfrom
fork-ci-4-audit
Open

potiuk wants to merge 2 commits into
fork-ci-3-reconcilerfrom
fork-ci-4-audit

Conversation

@potiuk

@potiuk potiuk commented Oct 15, 2026

Copy link
Copy Markdown
Member

Stacked on #74822. Part 4 of 5 of the AIP-120 implementation (design: #73378); this PR's base is the previous branch, so the diff shows only this layer.

breeze ci audit [--fix] checks gh, the upstream/origin remotes, the fork, your role, whether the fork's Tests (AMD) workflow is enabled or disabled as your role requires, fork main freshness and the current branch, printing the fix for each failure. Remote parsing moves out of ci upgrade into git_remotes.py and now matches apache/airflow exactly.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

🤖 Generated with Claude Code

@potiuk
potiuk added this pull request to stack #74827 October 15, 2026 22:48
@potiuk
potiuk removed this pull request from stack #74827 October 15, 2026 23:26
@potiuk
potiuk changed the base branch from fork-ci-3-reconciler to main October 15, 2026 23:26
@potiuk
potiuk changed the base branch from main to fork-ci-3-reconciler October 15, 2026 23:30
@potiuk
potiuk added this pull request to stack #74833 October 15, 2026 23:30
@potiuk
potiuk force-pushed the fork-ci-4-audit branch 2 times, most recently from 058ebe3 to 3b60129 Compare October 16, 2026 23:49
@potiuk
potiuk force-pushed the fork-ci-4-audit branch 2 times, most recently from 25c9e03 to 017ae71 Compare October 17, 2026 00:54
Comment thread dev/breeze/src/airflow_breeze/utils/ci_audit.py Outdated
Comment thread dev/breeze/src/airflow_breeze/commands/ci_commands.py Outdated
Comment thread dev/breeze/src/airflow_breeze/utils/ci_audit.py Outdated
Comment thread dev/breeze/src/airflow_breeze/utils/git_remotes.py Outdated
Comment thread dev/breeze/src/airflow_breeze/utils/ci_audit.py
Comment thread dev/breeze/src/airflow_breeze/utils/ci_audit.py
Comment thread dev/breeze/src/airflow_breeze/utils/ci_audit.py Outdated
Comment thread dev/breeze/src/airflow_breeze/utils/git_remotes.py
Fork CI only works when the contributor's remotes, fork and fork workflow are set up the way the gate and the reconciler expect, and committers must keep fork CI off so their pushes do not run twice. A read-only audit lets contributors verify all of that before pushing and offers the exact fix for anything missing. Remote parsing moves out of ci upgrade so both commands agree on what a correct setup is, and it now matches apache/airflow exactly instead of any URL containing it.

Generated-by: Claude Opus 5
Decide the role before the remote and fork checks, so a committer working from an apache/airflow clone is not told to set up a fork their pull requests do not use; those checks, and an enabled fork workflow, are informational for roles that run project CI, since a committer trying use fork ci needs the workflow enabled. Report a failed API call as could-not-check instead of a wrong fork or a missing workflow, and recognise ssh host aliases from ~/.ssh/config as GitHub remotes again, as breeze ci upgrade did before.

Generated-by: Claude Opus 5

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants