Repository navigation
Add MultiZoneConfig support to DataprocCreateClusterOperator and bump google-cloud-dataproc to 5.32.0 - #74910
Colin-Cheng wants to merge 1 commit into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
|
Quickest fix: git fetch upstream main && git rebase upstream/main
rm uv.lock && uv lock
git add uv.lock && git rebase --continue
git push --force-with-leaseAutomated nudge — ignore if you're not ready to rebase. This comment is updated in place on future |
| super().__init__(**kwargs) | ||
| if deferrable and polling_interval_seconds <= 0: | ||
| raise ValueError("Invalid value for polling_interval_seconds. Expected value greater than 0") | ||
| if isinstance(cluster_config, dict) and "gce_cluster_config" in cluster_config: |
There was a problem hiding this comment.
If we pass config just as dict will it fail? Is there strong reason for additional transformation code?
There was a problem hiding this comment.
Removed the custom MultiZoneConfig dataclass and __init__ conversion from dataproc.py (and the corresponding unit test), keeping the google-cloud-dataproc>=5.32.0 version bump and adding documentation with a multi_zone_config example in providers/google/docs/operators/cloud/dataproc.rst.
olegkachur-e
left a comment
There was a problem hiding this comment.
Thank you for the contribution! A few suggestions:
- Version bump is enough: with
google-cloud-dataproc>=5.32.0,DataprocCreateClusterOperatoralready passescluster_configto the API as is, so{"gce_cluster_config": {"multi_zone_config": {"target_shape": "ANY"}}}(or a nativedataproc_v1.MultiZoneConfig) works without operator changes. TheMultiZoneConfigdataclass and the conversion in__init__can be removed. - Docs: a short feature description and config example in
docs/operators/cloud/dataproc.rst, with a link to the official Dataproc docs, would be very welcome. - System test result: could you please share the result of a system test run with the cluster config modified to use
multi_zone_config(e.g.example_dataproc_cluster_deferrable.py)? - Rebase: please rebase on the latest
mainand regenerateuv.lockto resolve the conflict.
Thanks!
2601f6c to
6cc14a5
Compare
|
Thanks for the review @olegkachur-e! I have updated the PR to address your comments:
|
987116c to
876e1fe
Compare
MaksYermak
left a comment
There was a problem hiding this comment.
Hello @Colin-Cheng , thank you for the PR!
LGTM, @shahar1 what do you think about this PR?
8698aba to
98ba177
Compare
This change adds
MultiZoneConfigsupport toDataprocCreateClusterOperator(viacluster_config), allowing users to configure multi-zonal clusters across multiple zones within a region during Dataproc cluster creation. This functionality is enabled by bumping thegoogle-cloud-dataprocpackage to>=5.32.0.Was generative AI tooling used to co-author this PR?
Generated-by: Gemini CLI following the guidelines