Repository navigation
Conversation
…-in as bool | None Follow-up to apache#74673, addressing the post-merge review comment (apache#74673 (review)). The stand-in annotated `durable: bool` but defaulted it to an `object()` sentinel that was typed `Any` to keep mypy quiet. It now defaults to `None`, the value the operators already use for "not set" (they only forward `durable` when it is not `None`), so the annotation is accurate and mypy keeps checking the argument. No behaviour change: only an explicit `durable=True/False` warns below 3.3.
amoghrajesh
approved these changes
Oct 22, 2026
amoghrajesh
left a comment
amoghrajesh
left a comment
Contributor
There was a problem hiding this comment.
Preemptively approving with a nit.
…ixin stand-in The no-warning test only covered durable left out, so a change back to warning on an explicit None would have passed. It now runs with durable left out and with durable=None.
Contributor
Author
|
Thx @amoghrajesh for the review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #74673, addressing @amoghrajesh's post-merge review comment.
The
common.compatResumableJobMixinstand-in annotateddurable: boolbut defaulted it to anobject()sentinel, typedAnyonly to keep mypy quiet. It now defaults toNone:bool | Noneis what the argument actually takes.bool | AnyorAnywould also be honest, but a union withAnyswitches type checking off for the argument, sodurable="yes"would pass.durable: bool | None = Noneand only forwarddurablewhen it is notNone. The stand-in now reads "not set" the same way.No behaviour change: below Airflow 3.3, leaving
durableout stays silent and an explicitdurable=True/Falsestill warns that it has no effect.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines