Skip to content

Ignore the runner's OTEL_* variables in the observability shared tests - #75828

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:observability-tests-ignore-runner-otel-env
Oct 28, 2026
Merged

potiuk merged 1 commit into
apache:mainfrom
potiuk:observability-tests-ignore-runner-otel-env

Conversation

@potiuk

@potiuk potiuk commented Oct 27, 2026

Copy link
Copy Markdown
Member

The shared distribution tests run on the CI runner itself rather than in Breeze, so they inherit its environment. RunsOn runners set up their own OpenTelemetry collector and export OTEL_* variables for it, and those take precedence over the Airflow configuration. Six test_config_priorities cases in the observability shared library expect the endpoint from the configuration, so they fail on such a runner, as in #75827: https://github.com/apache/airflow/actions/runs/40591556559/job/122497135792

The tests now clear any inherited OTEL_* variable; the cases that need one still set it themselves. With OTEL_EXPORTER_OTLP_ENDPOINT=127.0.0.1:4318 and OTEL_EXPORTER_OTLP_PROTOCOL=grpc set, the suite has the same 6 failures without this change and passes with it.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Claude Opus 5)

Generated-by: Claude Code (Claude Opus 5) following the guidelines

🤖 Generated with Claude Code

Shared distribution tests run on the CI runner itself rather than in
Breeze, and RunsOn runners export OTEL_* variables for their own
OpenTelemetry collector. Those take precedence over the Airflow
configuration, so the tests expecting the endpoint from the configuration
failed on such runners.

Generated-by: Claude Opus 5
@potiuk
potiuk enabled auto-merge (squash) October 27, 2026 23:31

@henry3260 henry3260 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@potiuk
potiuk merged commit 09d0ea1 into apache:main Oct 28, 2026
69 checks passed
@potiuk
potiuk deleted the observability-tests-ignore-runner-otel-env branch October 28, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants