fix(seo): a11y + CLS polish (homepage contrast/headings + Showcase logos)#2063
Open
moonming wants to merge 2 commits into
Open
fix(seo): a11y + CLS polish (homepage contrast/headings + Showcase logos)#2063moonming wants to merge 2 commits into
moonming wants to merge 2 commits into
Conversation
- Darken low-contrast text to meet WCAG AA: - secondary greys #777 / #8a8a8a / #888 -> #6b6b6b (5.3:1) - CTA red text #e8433e -> #c7352f (the existing hover shade, ~5.3:1) on the Pathways / Integrations / AI-gateway CTAs and the comparison APISIX column - left the large bold hero stat value (passes AA-large) and the decorative aria-hidden flow arrow unchanged - Promote Pathways card titles h3 -> h2 to fix the homepage h1->h3 heading skip (styling is class-driven, so no visual change)
The Showcase user-logo wall sized logos with max-width/max-height only, so the browser reserved no space until each (lazy, variable-aspect) logo loaded. Give each logo a fixed 100x40 box with object-fit: contain plus matching width/height attributes: space is reserved (no layout shift), logos are not distorted, and the wall renders uniformly. The Plugin Hub logos use a 250x180 max and would need a deliberate box-reservation design pass, so they're intentionally left.
moonming
changed the title
Member
Author
|
Added a second commit: reserve a fixed 100×40 Plugin Hub logos left intentionally: they use a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Homepage accessibility polish — the P2 items from the homepage-rewrite audit (now that
fix/homepage-layouthas landed):#777/#8a8a8a/#888→#6b6b6b(~5.3:1)#e8433e→#c7352f(the existing hover shade in the palette, ~5.3:1) on the Pathways / Integrations / AI-gateway CTAs and the comparison APISIX columnaria-hiddenflow arrow unchangedh3→h2, fixing the homepageh1→h3skip. Styling is class-driven (.pathways__title), so there is no visual change.8 lines changed; no layout or structural changes.
Out of scope
<img>the CWV check flagged are on/showcase/and/plugins/, not the homepage (the homepage Integrations logos already have explicitwidth/height).Test plan
#6b6b6b5.3:1,#c7352f~5.3:1); class-drivenh2= no visual regression