GH-40640: [R] to_arrow() loses group_by()#49713
Merged
thisisnic merged 1 commit intoapache:mainfrom Apr 12, 2026
Merged
Conversation
|
|
github-actions
bot
added
Component: R
awaiting committer review
jonkeane
approved these changes
Apr 12, 2026
Member
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
Looks good, did you run the test before the change too?
Comment on lines
+193
to
+203
| test_that("to_arrow preserves grouping from duckdb tables", { | ||
| ds <- InMemoryDataset$create(example_data) | ||
|
|
||
| out <- ds |> | ||
| to_duckdb() |> | ||
| group_by(lgl) |> | ||
| to_arrow() | ||
|
|
||
| expect_s3_class(out, "arrow_dplyr_query") | ||
| expect_equal(dplyr::group_vars(out), "lgl") | ||
| }) |
Member
There was a problem hiding this comment.
I trust this fails before the changes in duckdb.R?
github-actions
bot
added
awaiting merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Roundtrip to duckdb loses grouping
What changes are included in this PR?
Reapply grouping
Are these changes tested?
Yup
Are there any user-facing changes?
Nah
AI usage
Done with Codex, but I went through it myself and am happy with it.