Skip to content

[Enrichment] Expose max_batch_duration_secs in SQL/BQ handlers (#38243)#38244

Open
prabhnoor0212 wants to merge 1 commit intoapache:masterfrom
prabhnoor0212:fix/enrichment-max-batch-duration-secs
Open

[Enrichment] Expose max_batch_duration_secs in SQL/BQ handlers (#38243)#38244
prabhnoor0212 wants to merge 1 commit intoapache:masterfrom
prabhnoor0212:fix/enrichment-max-batch-duration-secs

Conversation

@prabhnoor0212
Copy link
Copy Markdown
Contributor

What changed

  • Added max_batch_duration_secs passthrough to Python BigQueryEnrichmentHandler batching kwargs.
  • Added the same passthrough to Python CloudSQLEnrichmentHandler batching kwargs for table-based query configs.
  • Updated handler docs to mention batching duration support.
  • Added unit coverage for both handlers to verify:
    • duration is forwarded when set
    • duration is omitted by default
  • Added CHANGES.md entry under 2.74.0 bugfixes.

Why

Issue: #38243

Enrichment forwards handler-provided batch kwargs to RequestResponseIO -> BatchElements.
Previously only min/max batch size were exposed by these handlers, so users could not configure max_batch_duration_secs through them.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the enrichment handlers for BigQuery and CloudSQL by exposing the max_batch_duration_secs parameter. This allows users to configure the maximum time to buffer elements before emitting a batch, providing more granular control over the batching process in Apache Beam pipelines.

Highlights

  • Feature Enhancement: Added support for max_batch_duration_secs in both BigQueryEnrichmentHandler and CloudSQLEnrichmentHandler to allow better control over batching behavior.
  • Documentation: Updated handler documentation to reflect the new configuration parameter for batching duration.
  • Testing: Added comprehensive unit tests for both handlers to ensure the duration parameter is correctly forwarded when provided and omitted when not.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@prabhnoor0212 prabhnoor0212 force-pushed the fix/enrichment-max-batch-duration-secs branch from 5b4dc50 to c9e1fa0 Compare April 19, 2026 15:57
@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant