Conversation
Replaces manual list manipulation pattern with DebugOptions.add_experiment() which handles null-init and deduplication internally. Resolves apache#19347
… Java Replaces getExperiments()/modify/setExperiments() boilerplate with ExperimentalOptions.addExperiment() which handles null-init and deduplication. Resolves apache#19347
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a clean refactor of how pipeline experiments are managed in the codebase. By migrating from manual list operations to established helper methods, the implementation becomes more concise and robust, ensuring consistent handling of experiment flags without altering existing behavior. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
addresses #19347
Summary
Replace manual experiment list manipulation with the existing helper methods:
experiments.append(...)todebug_options.add_experiment(...)in 5 filesgetExperiments()/modify/setExperiments()pattern withExperimentalOptions.addExperiment(...)in 3 filesThis is a pure refactor — no behavior change. The helper methods already handle null-init and deduplication internally.
Files changed
Python:
sdks/python/apache_beam/pipeline.pysdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.pysdks/python/apache_beam/io/iobase_test.pysdks/python/apache_beam/io/external/xlang_parquetio_test.pysdks/python/apache_beam/runners/dataflow/internal/apiclient.pyJava:
runners/google-cloud-dataflow-java/src/main/java/.../DataflowPipelineTranslator.javarunners/google-cloud-dataflow-java/src/main/java/.../DataflowRunner.javarunners/google-cloud-dataflow-java/worker/src/main/.../GrpcWindmillServer.java