[test](regression) Isolate local Hive regression side effects#62579
Draft
xylaaaaa wants to merge 5 commits intoapache:masterfrom
Draft
[test](regression) Isolate local Hive regression side effects#62579xylaaaaa wants to merge 5 commits intoapache:masterfrom
xylaaaaa wants to merge 5 commits intoapache:masterfrom
Conversation
### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: Several local Hive regression suites mutate shared Docker Hive state through fixed table names, fixed database names, or writes against shared baseline tables. That makes it unsafe to reuse a Hive Docker environment across multiple pipelines or failed reruns. ### Release note None ### Check List (For Author) - Test: No need to test (workflow preparation only; only git diff check was run in this environment) - Behavior changed: Yes (regression suites now prefer per-run temporary Hive objects and best-effort cleanup) - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
The previous implementation included suite name and hivePrefix in the suffix, causing redundant and overly long names like: hive2_test_partitions_catalog_test_hive_partitions_hive2_ec0f5f5905ff (68 chars) New implementation generates cleaner names: hive2_test_partitions_catalog_ec0f5f5905ff (42 chars) This fixes test failures where catalog names were too verbose.
Contributor
Author
|
run buildall |
Fix variable scope issue where catalog_name was defined inside try block but accessed in finally block, causing MissingPropertyException.
Contributor
Author
|
run buildall |
- test_hive_ddl_text_format: Add database prefix to hive_docker queries - test_hive_partition_values_tvf: Add cleanup for partitionValuesDb in finally block These tests were failing because: 1. hive_docker queries need database.table format when using temp databases 2. Missing cleanup caused database not empty errors in subsequent runs
Contributor
Author
|
run buildall |
- test_hms_event_notification_multi_catalog: Add null checks for db1/db2 in finally block - test_hive_use_meta_cache_true: Replace order_qt with assertions to handle dynamic temp names These tests were failing because: 1. db1/db2 could be null if try block failed before assignment 2. order_qt expects fixed output but temp names are dynamic with UUID
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
This PR reduces shared local Hive Docker side effects across regression suites by moving many local-Hive write paths to per-run temporary Hive objects and best-effort cleanup. The goal is to make local Hive state safer for CI reuse and reruns.
Covered in this PR:
finallyblocks so failed runs also attempt to recover local Hive stateRemaining follow-up after this PR:
regression-test/suites/external_table_p0/hive/ddl/test_hive_ctas.groovyregression-test/suites/external_table_p0/hive/ddl/test_hive_ddl.groovyregression-test/suites/external_table_p0/hive/test_hive_case_sensibility.groovyRelease note
None
Check List (For Author)
git diff --checkwas run in this environment)