[fix](fe) Fix FE startup argument forwarding#62587
Open
w41ter wants to merge 1 commit intoapache:masterfrom
Open
[fix](fe) Fix FE startup argument forwarding#62587w41ter wants to merge 1 commit intoapache:masterfrom
w41ter wants to merge 1 commit intoapache:masterfrom
Conversation
Fix bin/start_fe.sh so FE startup options are forwarded as separate argv entries. This preserves helper and recovery-related option/value boundaries and fixes the cluster_snapshot option name passed to org.apache.doris.DorisFE.
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
gavinchou
approved these changes
Apr 17, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
No blocking issues found in bin/start_fe.sh.
Critical checkpoints:
- Goal: Met. The patch now forwards FE startup flags as separate argv entries and fixes the
--cluster_snapshotspelling. This matches the expectations inDorisFE.parseArgs()andEnv.getHelperNodes(). - Scope and minimality: Met. The change is small, focused, and limited to the startup wrapper.
- Concurrency: Not applicable. This is shell argument wiring only.
- Lifecycle and static initialization: Not applicable.
- Configuration changes: None.
- Compatibility: No storage, protocol, or rolling-upgrade compatibility impact. This only changes CLI argument forwarding.
- Parallel code paths: Covered. The
daemon,console, and default FE startup branches all use the new array-based forwarding. Theimageandversionpaths remain unchanged. - Special conditional checks: None added.
- Test coverage: No automated test was added, so shell-to-Java argument forwarding still relies on manual coverage. I traced the end-to-end flow against
DorisFE.parseArgs()andEnv.getHelperNodes()and did not find a blocking mismatch. - Observability: Unchanged. Existing startup logging remains sufficient.
- Transaction and persistence: Not applicable.
- Data writes and atomicity: Not applicable.
- FE-BE variable passing: Not applicable.
- Performance: No meaningful impact.
- Other issues: None found.
Residual risk:
- There is still no automated coverage for this shell and FE parser contract, so future edits in either layer could regress option forwarding without a dedicated test.
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Fix bin/start_fe.sh so FE startup options are forwarded as separate argv entries. This preserves helper and recovery-related option/value boundaries and fixes the cluster_snapshot option name passed to org.apache.doris.DorisFE.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)