Skip to content

[fix](fe) Fix FE startup argument forwarding#62587

Open
w41ter wants to merge 1 commit intoapache:masterfrom
w41ter:fix/start_fe
Open

[fix](fe) Fix FE startup argument forwarding#62587
w41ter wants to merge 1 commit intoapache:masterfrom
w41ter:fix/start_fe

Conversation

@w41ter
Copy link
Copy Markdown
Contributor

@w41ter w41ter commented Apr 17, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Fix bin/start_fe.sh so FE startup options are forwarded as separate argv entries. This preserves helper and recovery-related option/value boundaries and fixes the cluster_snapshot option name passed to org.apache.doris.DorisFE.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Fix bin/start_fe.sh so FE startup options are forwarded as separate argv entries.
This preserves helper and recovery-related option/value boundaries and fixes the
cluster_snapshot option name passed to org.apache.doris.DorisFE.
@w41ter
Copy link
Copy Markdown
Contributor Author

w41ter commented Apr 17, 2026

run buildall

@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 17, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@w41ter
Copy link
Copy Markdown
Contributor Author

w41ter commented Apr 17, 2026

/review

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found in bin/start_fe.sh.

Critical checkpoints:

  • Goal: Met. The patch now forwards FE startup flags as separate argv entries and fixes the --cluster_snapshot spelling. This matches the expectations in DorisFE.parseArgs() and Env.getHelperNodes().
  • Scope and minimality: Met. The change is small, focused, and limited to the startup wrapper.
  • Concurrency: Not applicable. This is shell argument wiring only.
  • Lifecycle and static initialization: Not applicable.
  • Configuration changes: None.
  • Compatibility: No storage, protocol, or rolling-upgrade compatibility impact. This only changes CLI argument forwarding.
  • Parallel code paths: Covered. The daemon, console, and default FE startup branches all use the new array-based forwarding. The image and version paths remain unchanged.
  • Special conditional checks: None added.
  • Test coverage: No automated test was added, so shell-to-Java argument forwarding still relies on manual coverage. I traced the end-to-end flow against DorisFE.parseArgs() and Env.getHelperNodes() and did not find a blocking mismatch.
  • Observability: Unchanged. Existing startup logging remains sufficient.
  • Transaction and persistence: Not applicable.
  • Data writes and atomicity: Not applicable.
  • FE-BE variable passing: Not applicable.
  • Performance: No meaningful impact.
  • Other issues: None found.

Residual risk:

  • There is still no automated coverage for this shell and FE parser contract, so future edits in either layer could regress option forwarding without a dedicated test.

@hello-stephen
Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. cloud dev/4.0.x dev/4.1.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants