GUACAMOLE-2324: Add tight back to encodings & disable JPEG by default - #707
Open
mathijs-ixon wants to merge 2 commits into
Open
GUACAMOLE-2324: Add tight back to encodings & disable JPEG by default#707mathijs-ixon wants to merge 2 commits into
mathijs-ixon wants to merge 2 commits into
Conversation
Contributor
|
@mathijs-ixon Thanks for the contribution. This will need a Jira issue created in our issue tracker, and the pull request and commit messages will need to be tagged with the Jira issue. https://guacamole.apache.org/open-source/ |
mathijs-ixon
changed the title
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently encountered some issues with users not being able to use our guacamole setup to connect to their VNC server. Apparently, their server only supported “tight” encoding. Per this message from 2016, this has been removed from the default encodings string in guacamole to prevent connections with JPEG compression in between, which hurts guacamole’s own PNG compression.
In libvncclient the default encodings string (which is used if not explicitly specified by the user) still includes “tight”.
In our case the user could explicitly ask for “tight” encoding and it would work, albeit with bad performance because indeed in this case JPEG was used by their server, because guacamole advertises this by default (because it is libvncclient’s default to allow JPEG).
This PR adds tight back to the default encodings string, and disables JPEG advertisement by default.
In our own tests our user could connect again without explicitly selecting tight, and the performance was now good.