ci: apply github workflow best practice (zizmor/codeql/asf-allowlist-check)#618
Merged
kevinjqliu merged 9 commits intoapache:mainfrom Apr 16, 2026
Merged
ci: apply github workflow best practice (zizmor/codeql/asf-allowlist-check)#618kevinjqliu merged 9 commits intoapache:mainfrom
kevinjqliu merged 9 commits intoapache:mainfrom
Conversation
kevinjqliu
commented
Apr 15, 2026
| version: 2 | ||
| updates: | ||
| # Maintain dependencies for GitHub Actions | ||
| - package-ecosystem: "github-actions" |
Contributor
Author
There was a problem hiding this comment.
add back dependabot for `github-actions, previously removed in #597
we now have asf-allowlist-check action which will check if any github actions are forbidden
| vcpkg install zlib:x64-windows nlohmann-json:x64-windows nanoarrow:x64-windows roaring:x64-windows cpr:x64-windows | ||
| - name: Setup sccache | ||
| uses: mozilla-actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad # v0.0.9 | ||
| uses: mozilla-actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad # v0.0.9 # zizmor: ignore[cache-poisoning] |
Contributor
Author
There was a problem hiding this comment.
use zizmor: ignore here for now. the risk is minimal, we can deal with it later
Comment on lines
+99
to
+107
| $ErrorActionPreference = "Stop" | ||
| cmd /c "call \"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat\" x64 && bash -lc \"ci/scripts/build_iceberg.sh `$(pwd) OFF ON\"" | ||
| if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE } | ||
| sccache --show-stats | ||
| - name: Build Example | ||
| shell: cmd | ||
| shell: pwsh | ||
| run: | | ||
| call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 | ||
| bash -c "ci/scripts/build_example.sh $(pwd)/example" | ||
| $ErrorActionPreference = "Stop" | ||
| cmd /c "call \"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat\" x64 && bash -lc \"ci/scripts/build_example.sh `$(pwd)/example\"" |
Contributor
Author
There was a problem hiding this comment.
this fix is suggested by claude, it lgtm
this PR's CI will run and verify
wgtmac
approved these changes
Apr 16, 2026
| jobs: | ||
| zizmor: | ||
| name: Run zizmor 🌈 | ||
| runs-on: ubuntu-latest |
Member
There was a problem hiding this comment.
Should we use ubuntu-24.04 to be consistent?
kevinjqliu
force-pushed
the
kevinjqliu/zizmor
branch
from
6bfa91d to
a435dd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding these 3 checks for all apache/iceberg* repos as part of apache/iceberg#15742