Repository navigation
fix(auth): stop BLOB view predicate lookups at LIMIT under query-auth - #1092
Open
plusplusjiajia wants to merge 2 commits into
Open
plusplusjiajia wants to merge 2 commits into
plusplusjiajia wants to merge 2 commits into
Conversation
A query-auth read with BLOB columns resolves the views its predicates read before LIMIT applies, a whole batch at a time, so it could look up references past the quota and fail on one no row needed. Read one candidate at a time in that case, as the unrestricted read already does.
plusplusjiajia
force-pushed
the
query-auth-blob-view-limit
branch
from
October 10, 2026 08:17
7ca0b92 to
a2a42bb
Compare
plusplusjiajia
marked this pull request as ready for review
October 10, 2026 09:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up to #1089. Under query-auth, predicates on BLOB views can resolve references beyond LIMIT and fail on an upstream row the result never needs. PK merge output and readers that ignore the requested batch size make a decoder batch-size override insufficient.
Brief change log
After merging, row authorization and masking, yield one candidate row at a time before resolving predicate views when LIMIT is set. The downstream predicate and LIMIT stop pulling once enough rows qualify.
Remove the
read.batch-size = 1override and reuse the view-resolution condition infinish_authorized_blobs. File decoding, authorization and masking retain normal batches.Tests
Retain the append data-evolution regression. Add overlapping-file PK regressions for deduplicate and partial-update, covering masked aliases, descriptor/value reads, projections, batch sizes 1/1024, zero/small limits, rejected candidates and errors when missing references are required.
Default/fulltext REST tests pass (120 each), as do the related core and DataFusion tests, formatting, and all-targets core clippy with the existing
nonminimal_boolallowance.Scope
Deferring output-only views until after BLOB payload predicates and LIMIT remains separate follow-up work. Per-row OR short-circuiting of view lookups is also outside this change.