Repository navigation
[Core] Preserve captured snapshot metadata and empty read views - #1098
Merged
JingsongLi merged 2 commits intoOct 11, 2026
Merged
Conversation
leaves12138
approved these changes
Oct 11, 2026
leaves12138
left a comment
There was a problem hiding this comment.
Reviewed Rust PR #1098 at head 5eb8cd6. The captured snapshot/empty-view handling is consistent across core scans, hybrid/PK/vector search, DataFusion system tables, and Python bindings. Targeted validation passed: cargo fmt --check; hybrid core tests 20/20; DataFusion hybrid tests 4/4; partition-count empty-view test 1/1; system-table empty-view test 1/1; time-travel tests 29/29; empty vector-filter and PK-vector retained-tag tests passed. No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Table::copy_with_pinned_snapshotcapture complete snapshot metadata or an explicitly empty read view, preserving the caller-resolved read schema.Noneinto the core Table.Why
PyPaimon already captures a snapshot before multimodal search and lookup. Its Native bridge currently transports only schema/options, so a captured empty view follows later commits and retained-tag searches can reopen an expired snapshot file. The existing Rust cache cannot distinguish an unresolved view from an explicitly empty one.
The implementation reuses the existing Table cache and resolution path. Snapshot metadata is shared across table copies. Java
PrimaryKeyVectorScanand search read plans provide the reference for reusing one complete snapshot across data/index/read stages.Tests
Paired Python PR: apache/paimon#10497 (draft until this Rust API is merged). It enables these existing Python read views through the common Native Table bridge and keeps CI building upstream Rust
main.