Repository navigation
feat(scan): read bucket metadata for manifest pruning - #850
Merged
JingsongLi merged 3 commits intoSep 17, 2026
Merged
Conversation
jianguotian
force-pushed
the
codex/manifest-bucket-pruning
branch
from
September 17, 2026 04:28
cdd5f58 to
017733e
Compare
JingsongLi
reviewed
Sep 17, 2026
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
Requirement fit: SUPPORTED. Implementation: CLEAN.
The new read-only _TOTAL_BUCKETS field is decoded from external manifest schemas without changing Rust serialization. Manifest filtering only acts when bucket metadata is internally valid and otherwise falls back to the existing scan, while retaining entry-level filtering as a correctness backstop. I found no regression in the changed paths. Verification: the dedicated external-schema and bucket-pruning tests passed. Review scope: metadata compatibility, bucket envelopes, legacy/invalid metadata, and full/incremental scan call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Use bucket metadata written by Java Paimon to skip irrelevant manifest files before Rust fetches and decodes their contents.
This PR is read-side only. It does not add or modify any Rust manifest-writing, compaction, or sorting behavior.
Changes
_TOTAL_BUCKETSfield from external manifest-list writer schemas without adding it to Rust's manifest-list writer schema._MIN_BUCKET,_MAX_BUCKET, and_TOTAL_BUCKETSwith the existing bucket-key predicate hash calculation._TOTAL_BUCKETSbut does not serialize it.Scope
TableCommitchanges_TOTAL_BUCKETSVerification
cargo fmt --checkcargo test -p paimon --lib— 2,835 passed, 2 ignoredcargo clippy -p paimon --lib --tests -- -D warnings -A clippy::unnecessary-castlumina/ffi.rs_TOTAL_BUCKETSdecoding, exact bucket selection, legacy fail-open behavior, unassigned buckets, and invalid bucket envelopesRelated Java work