Repository navigation
[python] Send the warehouse config parameter encoded once - #10357
Open
plusplusjiajia wants to merge 2 commits into
Open
plusplusjiajia wants to merge 2 commits into
plusplusjiajia wants to merge 2 commits into
Conversation
plusplusjiajia
marked this pull request as ready for review
October 4, 2026 12:33
Contributor
|
Please rebase. |
plusplusjiajia
force-pushed
the
fix/python-rest-path-encoding
branch
from
October 5, 2026 13:55
5a0e683 to
9c9cef5
Compare
plusplusjiajia
force-pushed
the
fix/python-rest-path-encoding
branch
from
October 5, 2026 14:25
9c9cef5 to
c471058
Compare
Member
Author
|
@JingsongLi Rebased. |
plusplusjiajia
force-pushed
the
fix/python-rest-path-encoding
branch
2 times, most recently
from
October 6, 2026 15:18
3c13f52 to
276550b
Compare
plusplusjiajia
force-pushed
the
fix/python-rest-path-encoding
branch
from
October 8, 2026 09:06
276550b to
99515f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The
warehouseconfig parameter is encoded twice:RESTApiencodes it andurlencodeencodes it again. Forfile:///tmp/paimon-warehousethe server receivesfile%3A%2F%2F%2Ftmp%2Fpaimon-warehouse. Java fixed the same bug in #8792. Since #10385 started encoding/, a warehouse such asa/bnow fails as well.table_detailsalso encodes the database name now, as Java does.Tests
Ports
RESTApiWarehouseEncodingTestandResourcePathsTest#testUrlEncode, and adds atable_detailscase. Its expected path comes from Java'sResourcePaths.