Repository navigation
[oss] Fix OSS retry strategy skipping throttling and 5xx errors with unparsable bodies - #10438
Merged
Merged
Conversation
…t be parsed When the OSS SDK cannot parse the error body of a 429/5xx response, it reports the error as InvalidResponse. OSSRetryStrategy refused to retry InvalidResponse before looking at the status, so a throttled request failed on its first attempt. For reads, hadoop-aliyun turns that failure into a null stream and the read fails with "Null IO stream". Decide by the HTTP status alone, so 429/5xx responses are retried even when their body cannot be parsed, while 4xx responses are still not retried.
sundapeng
changed the title
sundapeng
changed the title
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When the OSS SDK cannot parse the error body of a 429/5xx response, such as
503 QpsLimitExceeded, it reports the error asInvalidResponse.OSSRetryStrategytreatsInvalidResponseas non-retryable before it looks at the status, so a throttled request fails on its first attempt. Reads take the worst of it: hadoop-aliyun turns the failed GET into a null stream, its read-ahead task does not retry that, and the read fails withIOException: Null IO stream.OSSRetryStrategynow decides by the HTTP status alone, so 429/5xx responses are retried even when their body cannot be parsed. A 4xx response is still not retried.Tests
OSSRetryStrategyTest: 1 new case against a fake OSS endpoint and 1 updated case; 36 tests inpaimon-oss-implpassed.