Repository navigation
[python] Fix optional checksum compatibility for OSS and custom S3 endpoints - #10450
Merged
JingsongLi merged 10 commits intoOct 9, 2026
Merged
Conversation
XiaoHongbo-Hope
marked this pull request as ready for review
October 8, 2026 13:13
XiaoHongbo-Hope
marked this pull request as draft
October 8, 2026 13:13
XiaoHongbo-Hope
marked this pull request as ready for review
October 8, 2026 14:29
XiaoHongbo-Hope
marked this pull request as draft
October 8, 2026 14:33
XiaoHongbo-Hope
marked this pull request as ready for review
October 8, 2026 15:43
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
While upgrading PyArrow for LeRobot integration in #9821, we found that PyArrow 22/23 sends optional checksum trailers absent in 19. Real OSS rejects them with HTTP 400:
STREAMING-UNSIGNED-PAYLOAD-TRAILER is not supported.WHEN_REQUIREDfixes the tested writes by omitting optional checksums. A Content-MD5 header can retain checksum validation, but PyArrow exposes neither per-client checksum configuration nor per-part checksum headers. That alternative requires Arrow changes or another storage backend.On PyArrow 22+, automatically default
AWS_REQUEST_CHECKSUM_CALCULATION=WHEN_REQUIREDfor PyArrow-backed OSS and explicit S3 endpoints (including AWS), including subprocess reconstruction. No user setup is needed; explicit values win and required checksums remain enabled.This is process-wide. Set
fs.s3.checksum-compatibility.auto-configure=falseon all relevant catalogs before client creation to prevent configuration; existing settings remain. Older PyArrow versions do not apply this default.Validation
WHEN_REQUIRED. Test objects and multipart uploads cleaned up. DLF was not rerun.