Repository navigation
Conversation
Class.newInstance() has been deprecated since Java 9. Use getDeclaredConstructor().newInstance() instead and widen the catch clauses to ReflectiveOperationException, keeping the existing wrapping exceptions and messages. As a result, checked exceptions thrown by a constructor now arrive wrapped in an InvocationTargetException instead of being sneaky-thrown. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Class.newInstance()has been deprecated since Java 9.What changes are included in this PR?
Replace it with
getDeclaredConstructor().newInstance()in parquet-hadoop (ParquetInputFormat,ParquetOutputFormat, the crypto factories,KeyToolkit), parquet-thrift, parquet-column (Operators) and parquet-format-structures. The catch clauses are widened toReflectiveOperationException, keeping the existing wrapping exceptions and messages.Are these changes tested?
Covered by the existing tests of the touched modules.
Are there any user-facing changes?
A constructor that throws a checked exception is now reported wrapped (through the existing
BadConfigurationException/RuntimeExceptionwrappers) instead of being sneaky-thrown byClass.newInstance().Closes #3897
This pull request and its description were written by Isaac.