Remove deprecated FiniteDuration overloads in TimeoutDirectives and BasicDirectives (since 1.3.0)#1124
Open
He-Pin wants to merge 1 commit into
Open
Conversation
…ives and BasicDirectives (since 1.3.0) Motivation: The FiniteDuration overloads were deprecated since pekko-http 1.3.0 in favor of java.time.Duration overloads. Modification: Removed deprecated methods from Java API: - TimeoutDirectives.withRequestTimeout(Duration, Supplier) - TimeoutDirectives.withRequestTimeout(Duration, JFunction, Supplier) - BasicDirectives.extractStrictEntity(FiniteDuration, JFunction) - BasicDirectives.extractStrictEntity(FiniteDuration, Long, JFunction) - BasicDirectives.toStrictEntity(FiniteDuration, Supplier) - BasicDirectives.toStrictEntity(FiniteDuration, Long, Supplier) Removed unused FiniteDuration import and duplicate toStrictEntity method. Added MiMa filters for DirectMissingMethodProblem and IncompatibleMethTypeProblem in BasicDirectives, TimeoutDirectives, and Directives. Result: Deprecated API removed. Users should use java.time.Duration overloads. MiMa binary compatibility check passes.
He-Pin
force-pushed
the
remove/deprecated-finite-duration-directives
branch
from
0cda6ed to
14c3cdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FiniteDurationoverloads were deprecated since pekko-http 1.3.0 in favor ofjava.time.Durationoverloads.Modification
Removed 6 deprecated methods from Java API:
TimeoutDirectives.withRequestTimeout(Duration, Supplier)TimeoutDirectives.withRequestTimeout(Duration, JFunction, Supplier)BasicDirectives.extractStrictEntity(FiniteDuration, ...)(2 overloads)BasicDirectives.toStrictEntity(FiniteDuration, ...)(2 overloads)Removed unused
FiniteDurationimport. Added MiMa filters.Result
Deprecated API removed. Users should use
java.time.Durationoverloads.