Skip to content

Remove unused CustomCharsetByteStringRendering - #1492

Merged
He-Pin merged 1 commit into
apache:mainfrom
pjfanning:remove-custom-charset-rendering
Nov 18, 2026
Merged

He-Pin merged 1 commit into
apache:mainfrom
pjfanning:remove-custom-charset-rendering

Conversation

@pjfanning

@pjfanning pjfanning commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Motivation

CustomCharsetByteStringRendering has had no production callers since charset was removed from the Multipart types (19126b4). Its only reference was RenderingSpec, and it carried a TODO about an extra array copy in flushCharBuffer (candidate 5 in #1491).

Modification

Delete the internal class and its now-unused imports, and drop it from the shared RenderingSpec cases.

Result

Dead internal code and its TODO are gone. No public API changes.

Tests

  • sbt "http-core/testOnly org.apache.pekko.http.impl.util.RenderingSpec": 16 passed
  • sbt "http-tests/Test/compile": success
  • sbt "http-core/mimaReportBinaryIssues" (against 2.0.0): no issues
  • scalafmt --mode diff-ref=upstream/main: run

References

Refs #1491

Motivation:
CustomCharsetByteStringRendering has had no production callers since
charset was removed from the Multipart types. Its only reference was
RenderingSpec, and it carried a TODO about an extra array copy in
flushCharBuffer.

Modification:
Delete the internal class and its now-unused imports, and drop it from
the shared RenderingSpec cases.

Result:
Dead internal code and its TODO are gone. No public API changes.

Tests:
- sbt "http-core/testOnly org.apache.pekko.http.impl.util.RenderingSpec": 16 passed
- sbt "http-tests/Test/compile": success
- sbt "http-core/mimaReportBinaryIssues" (against 2.0.0): no issues
- scalafmt --mode diff-ref=upstream/main: run

References:
Refs apache#1491 - candidate 5
@pjfanning pjfanning added this to the 2.1.0 milestone Nov 18, 2026
@He-Pin
He-Pin merged commit f2b7f28 into apache:main Nov 18, 2026
6 checks passed
@pjfanning
pjfanning deleted the remove-custom-charset-rendering branch November 18, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants