Repository navigation
Remove unused CustomCharsetByteStringRendering - #1492
Merged
Merged
Conversation
Motivation: CustomCharsetByteStringRendering has had no production callers since charset was removed from the Multipart types. Its only reference was RenderingSpec, and it carried a TODO about an extra array copy in flushCharBuffer. Modification: Delete the internal class and its now-unused imports, and drop it from the shared RenderingSpec cases. Result: Dead internal code and its TODO are gone. No public API changes. Tests: - sbt "http-core/testOnly org.apache.pekko.http.impl.util.RenderingSpec": 16 passed - sbt "http-tests/Test/compile": success - sbt "http-core/mimaReportBinaryIssues" (against 2.0.0): no issues - scalafmt --mode diff-ref=upstream/main: run References: Refs apache#1491 - candidate 5
He-Pin
approved these changes
Nov 18, 2026
Philippus
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CustomCharsetByteStringRenderinghas had no production callers sincecharsetwas removed from theMultiparttypes (19126b4). Its only reference wasRenderingSpec, and it carried a TODO about an extra array copy influshCharBuffer(candidate 5 in #1491).Modification
Delete the internal class and its now-unused imports, and drop it from the shared
RenderingSpeccases.Result
Dead internal code and its TODO are gone. No public API changes.
Tests
sbt "http-core/testOnly org.apache.pekko.http.impl.util.RenderingSpec": 16 passedsbt "http-tests/Test/compile": successsbt "http-core/mimaReportBinaryIssues"(against 2.0.0): no issuesscalafmt --mode diff-ref=upstream/main: runReferences
Refs #1491