PHOENIX-7792 New file age check before processing during replay#2423
Open
Himanshu-g81 wants to merge 1 commit intoapache:PHOENIX-7562-feature-newfrom
Open
PHOENIX-7792 New file age check before processing during replay#2423Himanshu-g81 wants to merge 1 commit intoapache:PHOENIX-7562-feature-newfrom
Himanshu-g81 wants to merge 1 commit intoapache:PHOENIX-7562-feature-newfrom
Conversation
…e possibility of files being open during replay
tkhurana
reviewed
Apr 29, 2026
| files = replicationLogTracker.getNewFilesForRound(replicationRound); | ||
| List<Path> allFiles = replicationLogTracker.getNewFilesForRound(replicationRound); | ||
| LOG.info("Number of new files for round {} is {}", replicationRound, allFiles.size()); | ||
| long minAgeMs = getNewFileMinAgeMs(); |
Contributor
There was a problem hiding this comment.
This won't be changing right from one round to another right. We can avoid computing it everytime
| List<Path> allFiles = replicationLogTracker.getNewFilesForRound(replicationRound); | ||
| LOG.info("Number of new files for round {} is {}", replicationRound, allFiles.size()); | ||
| long minAgeMs = getNewFileMinAgeMs(); | ||
| while (!allFiles.isEmpty()) { |
Contributor
There was a problem hiding this comment.
I highly recommend adding isRunning check here.
Suggested change
| while (!allFiles.isEmpty()) { | |
| while (!allFiles.isEmpty() && isRunning) { |
Contributor
There was a problem hiding this comment.
@Himanshu-g81 As discussed offline we may not need this PR but I still think we should add the isRunning check to prevent stalling RS stop operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During replay, we now wait before processing a new file to ensure it's no longer being written by the source cluster. A file must be at least roundTime + configurable % old (default: 15%) before it becomes eligible. For the default 60s round time, that's 69s.
When some files are old enough, we process those immediately. When all remaining files are too young, we sleep for exactly the time needed until the oldest one becomes eligible.