PHOENIX-7815 Make WAL sync durability configurable#2434
Open
tkhurana wants to merge 1 commit intoapache:PHOENIX-7562-feature-newfrom
Open
PHOENIX-7815 Make WAL sync durability configurable#2434tkhurana wants to merge 1 commit intoapache:PHOENIX-7562-feature-newfrom
tkhurana wants to merge 1 commit intoapache:PHOENIX-7562-feature-newfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hbase.wal.hsyncHBase property (defaultfalse, matchingHRegion.DEFAULT_WAL_HSYNC).hbase.wal.hsync=true,sync()callshsync()(forces fsync to disk). Whenfalse(the default), it callshflush()(flushes to datanode memory only), trading durability for lower latency.LogFileWriterContextinto bothHDFSDataOutputandAsyncFSDataOutput, which previously hard-codedhsync()insync().Changes
LogFileWriterContext: readhbase.wal.hsyncfrom config (defaults toHRegion.DEFAULT_WAL_HSYNC=false); addgetUseHsync()/setUseHsync(); includeuseHsyncintoString().HDFSDataOutput/AsyncFSDataOutput: acceptuseHsyncin constructor;sync()dispatches tohsync()orhflush()based on the flag.LogFileWriter: propagatecontext.getUseHsync()when constructingHDFSDataOutput.LogFileFormatTestupdated for the new constructor arg;LogFileWriterSyncTestaddstestSyncWithHflushand setshbase.wal.hsync=trueexplicitly in the existing hsync test.Test plan
mvn test -pl phoenix-core -Dtest=LogFileWriterSyncTest— 5/5 passmvn test -pl phoenix-core -Dtest=LogFileFormatTest— 16/16 passmvn spotless:applyclean