Repository navigation
[SPARK-59034][INFRA] Use connect-rust-* fix versions in merge_connect_rust_pr.py - #60
Closed
HyukjinKwon wants to merge 1 commit into
Closed
HyukjinKwon wants to merge 1 commit into
HyukjinKwon wants to merge 1 commit into
Conversation
…_rust_pr.py ### What changes were proposed in this pull request? `resolve_jira_issue` in `dev/merge_connect_rust_pr.py` filtered the SPARK project versions to plain `x.y.z` names (`re.match(r"\d+\.\d+\.\d+", ...)`), which matches only the core Spark versions (4.2.0, 5.0.0, ...) and skips the `connect-rust-*` line. This makes it match `connect-rust-\d+\.\d+\.\d+` versions instead. ### Why are the changes needed? spark-connect-rust ships on its own `connect-rust-*` version line. With the old filter the merge tool offered/set core Spark fix versions on spark-connect-rust JIRAs, which then leaked into the core Spark release notes. Matching the `connect-rust-*` versions keeps these JIRAs in the connect-rust release notes. ### Does this PR introduce _any_ user-facing change? No. Committer-side merge tooling only. ### How was this patch tested? `python3 -m py_compile dev/merge_connect_rust_pr.py`. The regex change was verified against the current SPARK project versions: it now selects `connect-rust-0.1.0` and excludes core `x.y.z` versions. Co-authored-by: Isaac <no-reply@databricks.com>
zhengruifeng
approved these changes
Aug 27, 2026
HyukjinKwon
deleted the
gurwls223/fix-merge-script-connect-rust-fixversion
branch
September 7, 2026 22:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
resolve_jira_issueindev/merge_connect_rust_pr.pyfiltered the SPARK project versions to plainx.y.znames (re.match(r"\d+\.\d+\.\d+", ...)), which matches only the core Spark versions (4.2.0, 5.0.0, ...) and skips theconnect-rust-*line. This changes the filter to matchconnect-rust-\d+\.\d+\.\d+versions instead.Why are the changes needed?
spark-connect-rust ships on its own
connect-rust-*version line. With the old filter, the merge tool offered and set core Spark fix versions on spark-connect-rust JIRAs, which then leaked into the core Spark release notes. Matching theconnect-rust-*versions keeps these JIRAs in the connect-rust release notes where they belong.Does this PR introduce any user-facing change?
No. Committer-side merge tooling only.
How was this patch tested?
python3 -m py_compile dev/merge_connect_rust_pr.py. The regex was verified against the current SPARK project versions: it now selectsconnect-rust-0.1.0and excludes the corex.y.zversions.This pull request and its description were written by Isaac.