Skip to content

[MINOR][INFRA] Fix Rust coverage badge stuck at 0.0% (wrong llvm-cov JSON key) #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[MINOR][INFRA] Fix Rust coverage badge stuck at 0.0% (wrong llvm-cov JSON key) #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,19 @@ jobs:
with open("coverage-rust.json", "r") as f:
data = json.load(f)

# Extract line coverage percentage (or region if line not available)
# cargo-llvm-cov emits the llvm "export" format: the summary lives under
# data[0].totals.{lines,regions,functions}.percent. The previous code read
# data[0].line_coverage_percent, a key that does not exist, so it always fell
# back to 0 and the badge showed 0.0%. Use line coverage, falling back to
# region then function coverage.
coverage_pct = None
if "data" in data and len(data["data"]) > 0:
coverage_obj = data["data"][0]
if "line_coverage_percent" in coverage_obj:
coverage_pct = coverage_obj["line_coverage_percent"]
elif "region_coverage_percent" in coverage_obj:
coverage_pct = coverage_obj["region_coverage_percent"]
if data.get("data"):
totals = data["data"][0].get("totals", {})
for key in ("lines", "regions", "functions"):
metric = totals.get(key)
if isinstance(metric, dict) and "percent" in metric:
coverage_pct = metric["percent"]
break

if coverage_pct is None:
coverage_pct = 0
Expand Down
Loading